Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullish coalescing support #417

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Nullish coalescing support #417

wants to merge 4 commits into from

Conversation

sanex3339
Copy link
Contributor

@sanex3339 sanex3339 commented Jun 23, 2020 •
edited
Loading

I have no idea what I'm doing but it works.
Probably it can be done in a more simple way.

@sanex3339 sanex3339 changed the base branch from sanex3339-exponentiation-operator to master June 23, 2020 20:19
@sanex3339 sanex3339 mentioned this pull request Jul 7, 2020
Closed
@sanex3339 sanex3339 mentioned this pull request Jul 23, 2020
Merged
@sanex3339 sanex3339 force-pushed the nullish-coalescing-support branch from 3ea3706 to 121f9a8 Compare August 6, 2020 06:04
@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 6, 2020 •
edited
Loading

@bakkot, @michaelficarra Now let's do this!

@sanex3339
Copy link
Contributor Author

Looks like this one will take a bunch of the time too =(

@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 15, 2020 •
edited
Loading

@bakkot may you review this please? It would be nice to get this in good form before @michaelficarra see this.

@sanex3339
Copy link
Contributor Author

@michaelficarra any news?

@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 22, 2020 •
edited
Loading

And again two months have passed since the PR was created and still no response =(

bakkot
bakkot reviewed Aug 24, 2020
View reviewed changes
escodegen.js Outdated Show resolved Hide resolved
escodegen.js Outdated Show resolved Hide resolved
test/compare-acorn-es2020/nullish-coalescing.expected.js Show resolved Hide resolved
@sanex3339
Copy link
Contributor Author

@bakkot thank you, i updated the PR:
5646f11

bakkot
bakkot reviewed Aug 24, 2020
View reviewed changes
escodegen.js Outdated Show resolved Hide resolved
@sanex3339
Copy link
Contributor Author

@michaelficarra may you check it now?

@sanex3339
Copy link
Contributor Author

@michaelficarra ping. Please check this.

@sanex3339
Copy link
Contributor Author

@michaelficarra ping

@sanex3339
Copy link
Contributor Author

@michaelficarra this PR is still here. 3 months have left since it was created.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Sep 23, 2020 •
edited
Loading

@michaelficarra @Constellation ping
Let's celebrate the 3rd month that is passed without any attention to this PR.

@sanex3339
Copy link
Contributor Author

@michaelficarra ping

@sanex3339
Copy link
Contributor Author

@michaelficarra please check this

@sanex3339
Copy link
Contributor Author

@michaelficarra ping

1 similar comment
@sanex3339
Copy link
Contributor Author

@michaelficarra ping

@sanex3339
Copy link
Contributor Author

Seems it's definitely the time to create a fork.

@sanex3339
Copy link
Contributor Author

@michaelficarra Ping

@sanex3339
Copy link
Contributor Author

@michaelficarra last ping in hope that it will be merged and I wont create a fork with all my PRs

This was referenced Oct 31, 2020
Closed
Closed
@sanex3339
Copy link
Contributor Author

I created the fork with this feature:
https://www.npmjs.com/package/@javascript-obfuscator/escodegen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanex3339 @bakkot